Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Hide generated interface types in sv module #245

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

jawoznia
Copy link
Collaborator

@jawoznia jawoznia commented Oct 25, 2023

part of #114

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #245 (86e304e) into feat/generics_support (ad52fcf) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@                    Coverage Diff                    @@
##           feat/generics_support     #245      +/-   ##
=========================================================
- Coverage                  85.91%   85.85%   -0.07%     
=========================================================
  Files                         24       24              
  Lines                       1654     1654              
=========================================================
- Hits                        1421     1420       -1     
- Misses                       233      234       +1     
Files Coverage Δ
sylvia-derive/src/input.rs 92.98% <ø> (ø)
sylvia-derive/src/interfaces.rs 86.86% <100.00%> (-1.02%) ⬇️
sylvia-derive/src/message.rs 82.73% <100.00%> (ø)
sylvia-derive/src/multitest.rs 96.29% <100.00%> (ø)
sylvia-derive/src/remote.rs 100.00% <100.00%> (ø)
sylvia/tests/custom_msg.rs 100.00% <ø> (ø)
sylvia/tests/custom_query.rs 92.00% <ø> (ø)
sylvia/tests/dispatching.rs 93.33% <ø> (ø)
sylvia/tests/messages_generation.rs 0.00% <ø> (ø)
sylvia/tests/querier.rs 96.55% <100.00%> (ø)
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@hashedone hashedone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from impl_iface_on_generic_contract to feat/generics_support October 27, 2023 15:18
@jawoznia jawoznia force-pushed the generate_iface_types_in_sv_module branch from c1bba34 to 86e304e Compare October 27, 2023 15:19
@jawoznia jawoznia merged commit e255585 into feat/generics_support Oct 27, 2023
6 of 7 checks passed
@jawoznia jawoznia deleted the generate_iface_types_in_sv_module branch October 27, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants